I agree, Herbalife isn't that great at all it's also pretty much a con imo.
Eat right and train hard.
Eat 5-6 small meals a day (if you can fit it all in) not 3 big meals. Cut down on the carbs as this is what your using for energy, so if you have no carbs resources left your body will start using it's 'fat stores' for energy.
High protein - low carbs and med fats daily should be your intake.
As for the gym I go 5 times a week maybe 6 if I can fit it around work. I'm currently 'cutting' so I'm keeping my reps around the 10-12 mark for 3 to 4 sets per exercise and depending what body part I'm training usually about 6 exercises.
3 sets - 6 exercises for chest. But more exercises when training legs.
As for cardio I try to aim for 30 minutes max after hitting the free weights. 30 minutes after weight training is plenty, but on non weight days I do cardio for roughly an hour.
I aim to burn 300 calories just from doing my cardio and can hit this during my 30 minute cardio workout by walking on a treadmill on a 6-8% incline at about 6kph. Running is good for you but not for burning fat. But imo arguably the best cardio machine to burn fat is the step master.
Just makes sure to warm up on a treadmill (for instance) for 5-10 minutes and stretch also with a couple of warm up sets.
I get all this done within an hour and half at gym, so not long at all.